Recovers webpack magic comments and adds to import #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack's magic comments must be extracted from dynamic imports before the spec is passed to `matchDynamicImportValue`. If a match is found for these types of comments, they are appended to the rewritten import.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/emywb5bu6 |
FredKSchott
approved these changes
Oct 8, 2020
| @@ -602,7 +602,7 @@ import def, { | |||
| all/* , */, | |||
| } from '../web_modules/async.js'; | |||
| console.log(def, waterfall, all); | |||
| import(\\"../web_modules/array-flatten.js\\")" | |||
There was a problem hiding this comment.
I forgot we added this broken test case, way back when!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to snowpack. Please, let me know if there is anything missing from this PR. 🙇♂️
Changes
https://github.com/pikapkg/snowpack/blob/b21848be11041ad87656617b6b56a5084023e054/snowpack/src/rewrite-imports.ts#L36
matchDynamicImportValuestrips the magic comments and the result spec is passed to thereplaceImporthandler.The process begins in the
buildFilemethod of the build command:https://github.com/pikapkg/snowpack/blob/75ad50315d18d7d4deac0c6efc649b2b650282a8/snowpack/src/commands/build.ts#L195
This PR extracts Webpack's magic comments from dynamic imports before the spec is passed to
matchDynamicImportValue. If a match is found for these types of comments, they are appended to the rewritten import.Testing
All tests pass locally. The snapshot for
build.test.jshas been updated. Please, review this change as I am not sure if will affect snowpack's treeshaking logic.Docs
No docs were added for this change.