Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tailwind import path #1205

Merged
merged 4 commits into from
Oct 5, 2020
Merged

chore: update tailwind import path #1205

merged 4 commits into from
Oct 5, 2020

Conversation

stefanfrede
Copy link
Contributor

Changes

I removed the dist-part from the Tailwind CSS imports because otherwise purging and plugins are not working.

Testing

I used a markdown view to take a look at my changes.

Docs

Yes, because this is an update of the public documentation.

Otherwise Tailwinds purging and plugins are not working.
@vercel
Copy link

vercel bot commented Oct 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/por0a1p6s
✅ Preview: https://snowpack-git-cb85580b3fa0ceaf98e23723994fea4ef804bdae.pikapkg.vercel.app

@FredKSchott
Copy link
Owner

FredKSchott commented Oct 4, 2020

Oh, interesting. The code snippet is actually correct as is: you need the "dist" for it to work with vanilla CSS.

BUT, you're right that we don't show a snippet for PostCSS, where you actually can remove the dist and get better results. instead of replacing the existing snippet, can you add this as a new snippet, under the PostCSS sub-section immediately after it?

@FredKSchott
Copy link
Owner

LGTM! Did some small wordsmithing before merging, thanks for the contribution!

@FredKSchott FredKSchott merged commit 9a9c3ac into FredKSchott:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants