support dev streaming logs #1203
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/33w5q8wk8 |
FredKSchott
force-pushed
the
stream-dev-output
branch
from
e5677cb to
b2019c0
Compare
| stdOutput = stdOutput.replace(/\x1Bc/, '').replace(/\u001bc/, ''); | ||
| } | ||
| if (cmdProgram === 'tsc') { |
There was a problem hiding this comment.
related: WORKER_UPDATE was no longer used, so this entire block had essentially become a no-op. Safe to remove
FredKSchott
force-pushed
the
stream-dev-output
branch
from
94db5e0 to
b2019c0
Compare
FredKSchott
force-pushed
the
stream-dev-output
branch
from
b2019c0 to
2437172
Compare
| @@ -92,6 +93,7 @@ const configSchema = { | |||
| fallback: {type: 'string'}, | |||
| bundle: {type: 'boolean'}, | |||
| open: {type: 'string'}, | |||
| output: {type: 'string', enum: ['stream', 'dashboard']}, | |||
There was a problem hiding this comment.
I’m thinking about output as a CLI flag (e.g. snowpack dev --output=stream) and I’m slightly-against it because the way we’ve implemented these (code), it seems like it could conflict with a future output in another namespace (like if we added a buildOptions.output or installOptions.output).
Is there a more clear name that relates to logging than “output?” What about logStyle?
There was a problem hiding this comment.
eh tbh I think this is okay to wait until we hit that issue. We could just as easily choose a more specific name for that second "output" when we get to it. As mentioned above, the idea is to match the same "output" option that we support in the run plugin today.
Changes
Testing
Docs