Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce verbose file changed events in the logs #1190

Merged
merged 1 commit into from
Oct 2, 2020
Merged

reduce verbose file changed events in the logs #1190

merged 1 commit into from
Oct 2, 2020

Conversation

FredKSchott
Copy link
Owner

Before

Screen Shot 2020-10-02 at 2 00 40 PM

After

Screen Shot 2020-10-02 at 1 46 28 PM

Testing

  • Tested manually.

Docs

  • n/a

@FredKSchott FredKSchott requested a review from a team as a code owner October 2, 2020 21:01
@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/mck24ncj0
✅ Preview: https://snowpack-git-cleaner-log-output.pikapkg.vercel.app

@FredKSchott
Copy link
Owner Author

Note: I think this is an improvement, but this one is more personal preference than objective change. Open to thoughts for or against, before merging.

melissamcewen
melissamcewen approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@melissamcewen melissamcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great, I really like the [xX] format

@FredKSchott FredKSchott merged commit 93e3478 into master Oct 2, 2020
@FredKSchott FredKSchott deleted the cleaner-log-output branch October 2, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissamcewen melissamcewen melissamcewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @melissamcewen