Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fast refresh example to react/preact templates #1188

Merged
merged 1 commit into from
Oct 2, 2020
Merged

add fast refresh example to react/preact templates #1188

merged 1 commit into from
Oct 2, 2020

Conversation

FredKSchott
Copy link
Owner

Screen Shot 2020-10-02 at 1 02 26 PM

Changes

  • Needed to simplify the guide that @melissamcewen is working on
  • "XX Seconds" will persist if Fast Refresh/Prefresh is enabled (default), reset on HMR updates if not enabled

Testing

  • Tests updated + templates manually

Docs

  • N/A

@FredKSchott FredKSchott requested a review from a team as a code owner October 2, 2020 20:03
@vercel
Copy link

vercel bot commented Oct 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/i9zu34zot
✅ Preview: https://snowpack-git-csa-add-fast-refresh-example.pikapkg.vercel.app

@FredKSchott FredKSchott force-pushed the csa-add-fast-refresh-example branch from 704332a to 30469ca Compare October 2, 2020 20:03
melissamcewen
melissamcewen approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@melissamcewen melissamcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think this will help people understand the benefits of HMR for sure

@FredKSchott FredKSchott merged commit 55bbc83 into master Oct 2, 2020
@FredKSchott FredKSchott deleted the csa-add-fast-refresh-example branch October 2, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissamcewen melissamcewen melissamcewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @melissamcewen