Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSA - move config back into templates, out of app-scripts-* packages #1137

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

FredKSchott
Copy link
Owner

/cc @drwpow

Background

  • We created CSA apps following a model similar to create-react-app, where config was moved into a lower package so that it could be managed and upgraded by us, and not the final user.
  • We've come to learn that this was a misunderstanding of what a "starter app" would look like in Snowpack vs. Webpack. Because Snowpack is so much easier to configure, our goal isn't to hide away 100s of lines of bundler configuration complexity from you. Instead, our goal is to show you a simple config example and give you clear guidance on how to extend that configuration.

Changes

  • Remove references to app-scripts for everything except testing (given that we hope to move off of Jest soon, spending time migrating this config seems like a waste of effort).
  • Move app-scripts config into the templates themselves (mainly babel, tsconfig, and snowpack config files)
  • Add/clean up docs
  • Clean up some features missing across templates

Testing

  • Covered by existing tests.

@FredKSchott FredKSchott requested a review from a team as a code owner September 27, 2020 07:02
@vercel
Copy link

vercel bot commented Sep 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/6k7sgbpjn
✅ Preview: https://snowpack-git-remove-app-scripts-01.pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should the app-scripts-* directories just be deleted?

@FredKSchott FredKSchott merged commit 54fadca into master Sep 29, 2020
@FredKSchott FredKSchott deleted the remove-app-scripts-01 branch September 29, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants