-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the contributing docs #1114
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/7j1ed07cz |
CONTRIBUTING.md
Outdated
@@ -65,6 +92,14 @@ cd path/to/some-other-project | |||
snowpack dev --verbose --reload | |||
``` | |||
|
|||
To test a local version of the `create-snowpack-app` templates use | |||
|
|||
NOTE This does not work, trying to figure this one out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that could help: splitting this into two different snippets:
To test CLI changes: node /path/to/snowpack/create-snowpack-app/cli [my-new-dir] --template @snowpack/app-template-vue
To test a new template: npx create-snowpack-app [my-new-dir] --template /path/to/template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea 👍🏼
Let me know if I can help @melissamcewen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still get [ERROR] Unable to find "/Users/melissamcewen/sites/snowpack/create-snowpack-app/app-template-vue" in the npm registry.
with either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CONTRIBUTING.md
Outdated
@@ -65,6 +92,14 @@ cd path/to/some-other-project | |||
snowpack dev --verbose --reload | |||
``` | |||
|
|||
To test a local version of the `create-snowpack-app` templates use | |||
|
|||
NOTE This does not work, trying to figure this one out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea 👍🏼
Let me know if I can help @melissamcewen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Changes
I encountered a few snags when trying to update the Vue template and I thought I'd take a shot at addressing them in the docs.
Testing
Docs only