Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the contributing docs #1114

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Conversation

melissamcewen
Copy link
Contributor

Changes

I encountered a few snags when trying to update the Vue template and I thought I'd take a shot at addressing them in the docs.

Testing

Docs only

@melissamcewen melissamcewen requested a review from a team as a code owner September 22, 2020 21:26
@vercel
Copy link

vercel bot commented Sep 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/7j1ed07cz
✅ Preview: https://snowpack-git-melissamcewen-contrib-docs.pikapkg.vercel.app

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
@@ -65,6 +92,14 @@ cd path/to/some-other-project
snowpack dev --verbose --reload
```

To test a local version of the `create-snowpack-app` templates use

NOTE This does not work, trying to figure this one out
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that could help: splitting this into two different snippets:

To test CLI changes: node /path/to/snowpack/create-snowpack-app/cli [my-new-dir] --template @snowpack/app-template-vue

To test a new template: npx create-snowpack-app [my-new-dir] --template /path/to/template

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍🏼

Let me know if I can help @melissamcewen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get [ERROR] Unable to find "/Users/melissamcewen/sites/snowpack/create-snowpack-app/app-template-vue" in the npm registry. with either

Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
@@ -65,6 +92,14 @@ cd path/to/some-other-project
snowpack dev --verbose --reload
```

To test a local version of the `create-snowpack-app` templates use

NOTE This does not work, trying to figure this one out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍🏼

Let me know if I can help @melissamcewen

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@melissamcewen melissamcewen merged commit e0a2ecb into master Sep 25, 2020
@melissamcewen melissamcewen deleted the melissamcewen/contrib-docs branch September 25, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants