-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/app-template-vue-typescript #1088
Feature/app-template-vue-typescript #1088
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/7o51y3us9 |
need help for update test. 😭 |
"test": "echo \"Vue 3.0 test support is still in progress.\" && exit 1" | ||
}, | ||
"dependencies": { | ||
"vue": "^3.0.0-rc.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0.0 just shipped: https://github.com/vuejs/vue-next/releases/tag/v3.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded
You can update the snapshot with
But I don't have enough domain knowledge to say if these changes look good or not: |
For some reasons, some projects can only stay in Vue 2.x Does this works on Vue 2.x? |
The Snowpack Vue plugin only works with Vue 3.x. Vue 2.0 isn't an option fo us, the Vue team changed the compiler pretty dramatically from 2->3 and we can't support both versions of the Vue compiler. |
could we publish 2 vue plugin? one for vue 3, another for vue 2. |
If someone wants to work on it, I would love to feature a Vue v2 plugin as a community plugin! But given that Vue v3 is now live and claims backward-compatability for Vue v2, it no longer makes sense for us to maintain this ourselves as an official plugin |
a73dcb4
to
8daa222
Compare
8daa222
to
82583dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I love the different examples of JSX, TSX, TSX + Vue, etc. All very helpful.
To @gr2m’s question, I skimmed the snapshot diffs and nothing jumped out to me. I think this is good to merge (pending the easy-to-fix yarn.lock
conflict).
Changes
add app-template-vue-typescript template
fix @snowpack/app-scripts-vue build bug
If we use
/web_modules/vue.js
here, the build result will run failed. Because absolute path import will be ignore when tree shaking. So we need to change it.https://github.com/pikapkg/snowpack/compare/master...Akimyou:feature/app-template-vue-typescript?expand=1#diff-460291335ddc08075bf891e8e0c5f93fL99
Testing
Demo Repo: https://github.com/Akimyou/snowpack/tree/feature/app-template-vue-typescript-demo
TODO: