Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(preact-template) - add new babel plugin to enable context HMR #1080

Merged
merged 1 commit into from
Sep 17, 2020
Merged

(preact-template) - add new babel plugin to enable context HMR #1080

merged 1 commit into from
Sep 17, 2020

Conversation

JoviDeCroock
Copy link
Contributor

This adds the new babel plugin for prefresh, the test can be found here https://github.com/JoviDeCroock/prefresh/blob/main/test/index.test.js#L208

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner September 17, 2020 19:24
@vercel
Copy link

vercel bot commented Sep 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/p99pwcxra
✅ Preview: https://snowpack-git-fork-jovidecroock-new-babel-plugin.pikapkg.vercel.app

@JoviDeCroock JoviDeCroock changed the title add new babel plugin to enable context HMR (preact-template) - add new babel plugin to enable context HMR Sep 17, 2020
FredKSchott
FredKSchott approved these changes Sep 17, 2020
View reviewed changes
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you confirm that you tested this as working in the CSA app?

@JoviDeCroock
Copy link
Contributor Author

@FredKSchott I've tested it here and worked correctly for me

@FredKSchott
Copy link
Owner

Great!

@FredKSchott FredKSchott merged commit 42e48f3 into FredKSchott:master Sep 17, 2020
@JoviDeCroock JoviDeCroock deleted the new-babel-plugin branch September 17, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @FredKSchott