Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back "tsc" to CSA react scripts #1071

Merged
merged 1 commit into from
Sep 18, 2020
Merged

add back "tsc" to CSA react scripts #1071

merged 1 commit into from
Sep 18, 2020

Conversation

FredKSchott
Copy link
Owner

@FredKSchott FredKSchott commented Sep 17, 2020 •
edited
Loading

Changes

  • Adds back the automatic TypeScript runner for React + TypeScript CSA apps
  • Not sure when or why this got removed, but it shouldn't have
  • Related: I think this overall "app-scripts" system could be simplified, starting to think this "app-scripts" concept does more harm than good (confusing)

Testing

  • Covered by existing csa build test.

@FredKSchott FredKSchott requested a review from a team as a code owner September 17, 2020 05:57
@vercel
Copy link

vercel bot commented Sep 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/84b38mpmc
✅ Preview: https://snowpack-git-add-back-react-tsc.pikapkg.vercel.app

@FredKSchott FredKSchott changed the title add back react typescript support add back "tsc" to CSA react scripts Sep 17, 2020
@FredKSchott FredKSchott merged commit 439d3f4 into master Sep 18, 2020
@FredKSchott FredKSchott deleted the add-back-react-tsc branch September 18, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @drwpow