Skip to content

Commit

Permalink
remove svelte-check run-script from svelte templates
Browse files Browse the repository at this point in the history
  • Loading branch information
@FredKSchott
FredKSchott committed Oct 30, 2020
1 parent 80e49fd commit c5322f2
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 11 deletions.
1 change: 0 additions & 1 deletion create-snowpack-app/app-template-svelte-typescript/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"@types/snowpack-env": "^2.3.0",
"jest": "^26.2.2",
"snowpack": "^2.15.1",
"svelte-check": "^1.0.0",
"svelte-preprocess": "^4.0.8",
"typescript": "^4.0.0"
},
Expand Down
4 changes: 0 additions & 4 deletions create-snowpack-app/app-template-svelte-typescript/snowpack.config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ module.exports = {
'@snowpack/plugin-svelte',
'@snowpack/plugin-dotenv',
'@snowpack/plugin-typescript',
[
'@snowpack/plugin-run-script',
{cmd: 'svelte-check --output human', watch: '$1 --watch', output: 'stream'},
],
],
install: [
/* ... */
Expand Down
3 changes: 1 addition & 2 deletions create-snowpack-app/app-template-svelte/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
"@testing-library/jest-dom": "^5.5.0",
"@testing-library/svelte": "^3.0.0",
"jest": "^26.2.2",
"snowpack": "^2.15.1",
"svelte-check": "^1.0.0"
"snowpack": "^2.15.1"
},
"gitHead": "a01616bb0787d56cd782f94cecf2daa12c7594e4"
}
4 changes: 0 additions & 4 deletions create-snowpack-app/app-template-svelte/snowpack.config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ module.exports = {
plugins: [
'@snowpack/plugin-svelte',
'@snowpack/plugin-dotenv',
[
'@snowpack/plugin-run-script',
{cmd: 'svelte-check --output human', watch: '$1 --watch', output: 'stream'},
],
],
install: [
/* ... */
Expand Down

4 comments on commit c5322f2

@vercel
Copy link

@vercel vercel bot commented on c5322f2 Oct 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

@CrowdHailer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredKSchott can I ask why svelte-check was removed.
When starting a new project I no longer get typescript warnings from ts code in components. I do still get warnings from ts files.

@FredKSchott
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add it back if you'd like! new users were overwhelmed and had trouble understanding what was snowpack and what was svelte-check

@CrowdHailer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting, is it worth documenting.
Speaking as a new user to snowpack, I was rather surprised that I got errors from a .ts file and not from the svelte file. it certainly felt like a mismatch with expectations.
Maybe though work on svelte kit will resolve some of these ergonomics.

Please sign in to comment.