handle plugin buffer response (#950)

FredKSchott · Aug 31, 2020 · b112148 · b112148
1 parent d484739
commit b112148
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/snowpack/src/build/build-pipeline.ts b/snowpack/src/build/build-pipeline.ts
@@ -62,7 +62,7 @@ async function runPipelineLoadStep(
 
       validatePluginLoadResult(step, result);
 
-      if (typeof result === 'string') {
+      if (typeof result === 'string' || Buffer.isBuffer(result)) {
         const mainOutputExt = step.resolve.output[0];
         return {
           [mainOutputExt]: {
@@ -139,7 +139,7 @@ async function runPipelineTransformStep(
         });
         logger.debug(`✔ transform() success [${debugPath}]`, {name: step.name});
         // if step returned a value, only update code (don’t touch .map)
-        if (typeof result === 'string') {
+        if (typeof result === 'string' || Buffer.isBuffer(result)) {
           output[destExt].code = result;
           output[destExt].map = undefined;
         } else if (result && typeof result === 'object' && (result as {result: string}).result) {

diff --git a/snowpack/src/commands/dev.ts b/snowpack/src/commands/dev.ts
@@ -29,7 +29,7 @@ import isCompressible from 'compressible';
 import merge from 'deepmerge';
 import etag from 'etag';
 import {EventEmitter} from 'events';
-import {existsSync, promises as fs, readFileSync, statSync, createReadStream} from 'fs';
+import {createReadStream, existsSync, promises as fs, readFileSync, statSync} from 'fs';
 import http from 'http';
 import HttpProxy from 'http-proxy';
 import http2 from 'http2';

diff --git a/snowpack/src/config.ts b/snowpack/src/config.ts
@@ -728,7 +728,8 @@ export function validatePluginLoadResult(
   if (!result) {
     return;
   }
-  if (typeof result === 'string' && plugin.resolve!.output.length !== 1) {
+  const isValidSingleResultType = typeof result === 'string' || Buffer.isBuffer(result);
+  if (isValidSingleResultType && plugin.resolve!.output.length !== 1) {
     handleConfigError(
       `[plugin=${pluginName}] "load()" returned a string, but "resolve.output" contains multiple possible outputs. If multiple outputs are expected, the object return format is required.`,
     );