Added test for preloadModules option (#1399)

* added test for preloadmodules * corrected function name
FredKSchott · Oct 26, 2020 · 6473682 · 6473682 · vercel · Oct 26, 2020
1 parent 99f67f7
commit 6473682
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 1 deletion.
diff --git a/plugins/plugin-optimize/test/__snapshots__/plugin.test.js.snap b/plugins/plugin-optimize/test/__snapshots__/plugin.test.js.snap
@@ -7,13 +7,47 @@ exports[`@snowpack/plugin-optimize minimal - no minification: fs.writeFileSync 1
 exports[`@snowpack/plugin-optimize minimal - no options: console.log 1`] = ``;
 
 exports[`@snowpack/plugin-optimize minimal - no options: fs.writeFileSync 1`] = `
+FILE: stubs/minimal/esm_example.js
+export default function e(){return console.log("example"),1}
+
+
+--------------------------------------------------------------------------------
+
 FILE: stubs/minimal/index.html
 <!DOCTYPE html><html lang="en"><head><meta charset="UTF-8"><title>Minimal test</title><link rel="stylesheet" href="style.css"></head><body><script type="module" src="index.js"></script></body></html>
 
 --------------------------------------------------------------------------------
 
 FILE: stubs/minimal/index.js
-(()=>{function n(o){console.log(o)}n("test")})();
+import"./esm_example.js";(()=>{function e(m){console.log(m)}e("test")})();
+
+
+--------------------------------------------------------------------------------
+
+FILE: stubs/minimal/style.css
+body{border:1px solid red}
+`;
+
+exports[`@snowpack/plugin-optimize no HTML minification, with preloadModules: console.log 1`] = ``;
+
+exports[`@snowpack/plugin-optimize no HTML minification, with preloadModules: fs.writeFileSync 1`] = `
+FILE: stubs/minimal/esm_example.js
+export default function e(){return console.log("example"),1}
+
+
+--------------------------------------------------------------------------------
+
+FILE: stubs/minimal/index.html
+<!DOCTYPE html><html lang="en"><head><meta charset="UTF-8"><title>Minimal test</title><link rel="stylesheet" href="style.css">  <!-- @snowpack/plugin-optimize] Add modulepreload to improve unbundled load performance (More info: https://developers.google.com/web/updates/2017/12/modulepreload) -->
+    <link rel="modulepreload" href="/esm_example.js" />
+  </head><body><script type="module" src="index.js"></script>  <!-- [@snowpack/plugin-optimize] modulepreload fallback for browsers that do not support it yet -->
+    <script type="module" src="/esm_example.js"></script>
+  </body></html>
+
+--------------------------------------------------------------------------------
+
+FILE: stubs/minimal/index.js
+import"./esm_example.js";(()=>{function e(m){console.log(m)}e("test")})();
 
 
 --------------------------------------------------------------------------------

diff --git a/plugins/plugin-optimize/test/plugin.test.js b/plugins/plugin-optimize/test/plugin.test.js
@@ -54,4 +54,22 @@ describe('@snowpack/plugin-optimize', () => {
     expect(fs.writeFileSync).toMatchSnapshot('fs.writeFileSync');
     expect(console.log).toMatchSnapshot('console.log');
   });
+
+  it('no HTML minification, with preloadModules', async () => {
+      const pluginInstance = plugin(
+      {
+          buildOptions: {},
+      },
+      {
+          minifyHTML: false,
+          preloadModules: true
+      })
+
+      await pluginInstance.optimize({
+          buildDirectory: path.resolve(__dirname, 'stubs/minimal/'),
+      });
+
+      expect(fs.writeFileSync).toMatchSnapshot('fs.writeFileSync');
+      expect(console.log).toMatchSnapshot('console.log');
+  });
 });
diff --git a/plugins/plugin-optimize/test/stubs/minimal/esm_example.js b/plugins/plugin-optimize/test/stubs/minimal/esm_example.js
@@ -0,0 +1,4 @@
+export default function esm_example() {
+    console.log('example')
+    return 1
+}
diff --git a/plugins/plugin-optimize/test/stubs/minimal/index.js b/plugins/plugin-optimize/test/stubs/minimal/index.js
@@ -1,3 +1,5 @@
+import esm_example from './esm_example.js'
+
 (() => {
   function n(o) {
     console.log(o);