Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitigate potential _safeMint reentrancy #1

Merged
merged 1 commit into from
Apr 11, 2022
Merged

mitigate potential _safeMint reentrancy #1

merged 1 commit into from
Apr 11, 2022

Conversation

0xalpharush
Copy link
Contributor

I recalled samczsun's write-up while browsing the code and figured I'd submit a PR.

If desired, ERC721._mint or a reentrancy guard could be used instead of the changes I've made.

@0xalpharush 0xalpharush mentioned this pull request Apr 7, 2022
Closed
@FrankieIsLost
Copy link
Owner

Thank you!

@FrankieIsLost FrankieIsLost merged commit 41f3174 into FrankieIsLost:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xalpharush @FrankieIsLost