Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the tag suffix is only added when it is missing #2208

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

johscheuer
Copy link
Member

Description

Ensure that the tag suffix is only added when it is missing. This should prevent cases like sidecar-1-1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran some manual e2e tests for this.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Feb 5, 2025
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2de45c9
  • Duration 2:33:02
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-lgtm

@johscheuer johscheuer merged commit 9d69a96 into FoundationDB:main Feb 7, 2025
8 checks passed
@johscheuer johscheuer deleted the fix-tag-suffix branch February 7, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants