Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for fdbclient and lock client to see what subreconciler issued the command #2116

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

johscheuer
Copy link
Member

@johscheuer johscheuer commented Aug 27, 2024

Description

Those changes make use of the same logger that the (sub)reconciler uses, that way it's easier to track back which reconciler issued the command. In addition I added a trace ID field to make it easier to track a single reconcile run.

Fixes: #2118

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Ran unit tests and e2e test will be running.

Documentation

Follow-up

@johscheuer johscheuer requested a review from nicmorales9 August 27, 2024 14:13
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a83c6f8
  • Duration 2:55:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 48210ff
  • Duration 3:03:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample log lines:

{"level":"info","ts":"2024-08-27T15:14:08Z","logger":"controller","msg":"Chose connection option","namespace":"pr-1023-ep3owrwf","cluster":"fdb-cluster-5793tutp","traceID":"b52717dc-d719-439d-964d-2755f3e8e826","connectionString":"fdb_cluster_...."}
{"level":"info","ts":"2024-08-27T15:14:08Z","logger":"controller.fdbclient","msg":"Fetch values from FDB","namespace":"pr-1023-ep3owrwf","cluster":"fdb-cluster-5793tutp","traceID":"b52717dc-d719-439d-964d-2755f3e8e826","key":"\ufffd\ufffd/status/json"}

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@johscheuer
Copy link
Member Author

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 48210ff
  • Duration 3:03:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

I checked those failures and they don't seem to be related to the code changes.

@johscheuer johscheuer merged commit 8d2374e into FoundationDB:main Aug 28, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the improve-logging branch August 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid changing coordinators that are in maintenance mode
3 participants