-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging for fdbclient and lock client to see what subreconciler issued the command #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er issued the command
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Aug 28, 2024
johscheuer
commented
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample log lines:
{"level":"info","ts":"2024-08-27T15:14:08Z","logger":"controller","msg":"Chose connection option","namespace":"pr-1023-ep3owrwf","cluster":"fdb-cluster-5793tutp","traceID":"b52717dc-d719-439d-964d-2755f3e8e826","connectionString":"fdb_cluster_...."}
{"level":"info","ts":"2024-08-27T15:14:08Z","logger":"controller.fdbclient","msg":"Fetch values from FDB","namespace":"pr-1023-ep3owrwf","cluster":"fdb-cluster-5793tutp","traceID":"b52717dc-d719-439d-964d-2755f3e8e826","key":"\ufffd\ufffd/status/json"}
nicmorales9
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
I checked those failures and they don't seem to be related to the code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Those changes make use of the same logger that the (sub)reconciler uses, that way it's easier to track back which reconciler issued the command. In addition I added a trace ID field to make it easier to track a single reconcile run.
Fixes: #2118
Type of change
Please select one of the options below.
Discussion
Testing
Ran unit tests and e2e test will be running.
Documentation
Follow-up