This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Stop manually generating Cabal macros. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out they're generated automatically by GHC since version 8.0, as long as we pass the right package name and version. That's now possible as of tweag/rules_haskell#246. I'll hold off merging this PR until that one goes in, then I'll rebase to `rules_haskell` master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out they're generated automatically by GHC since version 8.0,
as long as we pass the right package name and version. That's now possible
as of tweag/rules_haskell#246.
This change bumps the
rules_haskelldependency, and also adds backnetworksince it builds now. (As of the above change rules_haskell now passes through thedefinesattribute ofcc_library, which is enough to fix that issue.)