feat: social-login #128
feat: social-login #128
Conversation
🦋 Changeset detectedLatest commit: f9066bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit f9066bf.
☁️ Nx Cloud last updated this comment at |
ryanbas21
force-pushed
the
sdks-3718
branch
3 times, most recently
from
867baf3 to
e3fbe10
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (17.35%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 47.32% 50.00% +2.67%
==========================================
Files 30 21 -9
Lines 1327 1232 -95
Branches 169 163 -6
==========================================
- Hits 628 616 -12
+ Misses 699 616 -83
🚀 New features to boost your workflow:
|
| @@ -17,14 +17,23 @@ const config: PlaywrightTestConfig = { | |||
| trace: process.env.CI ? 'on-first-retry' : 'retain-on-failure', | |||
| }, | |||
| webServer: [ | |||
| process.env.CI == 'false' | |||
There was a problem hiding this comment.
added this for the watch-deps so that changes are reloaded when running playwrights ui mode
|
Deployed fc9bea7 to https://ForgeRock.github.io/ping-javascript-sdk/pr-128/fc9bea7ead1c0da4e5ae6f137a4cf810b9ff845c branch gh-pages in ForgeRock/ping-javascript-sdk |
| if (collectorType === 'SocialLoginCollector' && 'links' in field) { | ||
| /** | ||
| * Social Login Collector will not have a `key` | ||
| * So we should _always_ have this error | ||
| * when building this collector, | ||
| * so lets reset it if we do. | ||
| * | ||
| * | ||
| * Until Davinci team adds a key that is. | ||
| */ | ||
| if (error.includes('Key is not found in the field object. ')) { | ||
| error = ''; |
There was a problem hiding this comment.
Should we just pull this out of the returnActionCollector? Maybe this should use its own function. Technically, it's quite different as all the other actions do not result in redirects.
| * @param collector @SocialLoginCollector | ||
| * @returns unknown | ||
| */ | ||
| socialLoginHandler: (collector: SocialLoginCollector) => { |
There was a problem hiding this comment.
This method should return a function that can be called when the button is clicked. It should match the same patter as the other "collector" update methods.
There was a problem hiding this comment.
Let's make sure our naming is consistent with native. I think they use externalIdP or something like that. Can you check?
ryanbas21
force-pushed
the
sdks-3718
branch
3 times, most recently
from
bf70538 to
aaf4fe9
Compare
we added a new type, which made links not guaranteed on the fields object
saving work at this point google social login works.
fix tests from previous commit
fix the tests
small pr to update type misses and rename the top level api handler
refactor social login
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-3718
Description
adds social login via davinci/pingone. supports Google and Facebook, while Apple should work, there are errors being reported to davinci team.