Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

FC069: Ensure standardized license defined in metadata #530

Merged
merged 4 commits into from
Apr 8, 2017
Merged

FC069: Ensure standardized license defined in metadata #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77915cb
FC069: Ensure standardized license defined in metadata
tas50 Mar 31, 2017
4c10ab9
Add spec for FC069
tas50 Apr 8, 2017
0d40f9a
Handle Chef-DK's extra non-standard license
tas50 Apr 8, 2017
611dc92
Convert FC063 FC064 and FC065 to rspec
tas50 Apr 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions features/063_cookbook_incorrectly_depends_on_itself.feature
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions features/064_check_for_no_issues_url.feature
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions features/065_check_for_no_source_url.feature
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions features/step_definitions/cookbook_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,47 +2505,3 @@ class Site < Chef::Resource::LWRPBase
version magic_version_generator('and its args')
}
end

Given(/^a cookbook with metadata that (includes|does not include) a self dependency$/) do |includes|
write_metadata %Q{
name 'bar'
depends 'baz'
#{"depends 'bar'" if includes == 'includes'}
}
end

Then(/^the metadata with self dependency warning 063 should be (shown|not shown) against the metadata file$/) do |show_warning|
if show_warning == "shown"
expect_warning("FC063", :file => "metadata.rb", :line => 3, :expect_warning => true)
else
expect_warning("FC063", :file => "metadata.rb", :expect_warning => false)
end
end

Given(/^a cookbook with metadata that (includes|does not include) a issues_url keyword$/) do |includes|
write_metadata %Q{
#{"issues_url 'http://github.com/foo/bar_cookbook/issues'" if includes == 'includes'}
}
end

Given(/^a cookbook with metadata that includes a issues_url expression$/) do
write_metadata "issues_url an(expression)"
end

Then(/^the metadata missing issues_url warning 064 should be (shown|not shown) against the metadata file$/) do |show_warning|
expect_warning("FC064", :file => "metadata.rb", :expect_warning => show_warning == "shown")
end

Given(/^a cookbook with metadata that (includes|does not include) a source_url keyword$/) do |includes|
write_metadata %Q{
#{"source_url 'http://github.com/foo/bar_cookbook/'" if includes == 'includes'}
}
end

Then(/^the metadata missing source_url warning 065 should be (shown|not shown) against the metadata file$/) do |show_warning|
expect_warning("FC065", :file => "metadata.rb", :expect_warning => show_warning == "shown")
end

Given(/^a cookbook with metadata that includes a source_url expression$/) do
write_metadata "source_url an(expression)"
end
Loading