Add versions to Readme list #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
approved these changes
Nov 29, 2022
| @@ -1,3 +1,5 @@ | |||
| <img align="right" width="200px" src="https://github.com/FluxML/Optimisers.jl/raw/master/docs/src/assets/logo.png"> | |||
There was a problem hiding this comment.
Suggested change
| <img align="right" width="200px" src="https://github.com/FluxML/Optimisers.jl/raw/master/docs/src/assets/logo.png"> | |
| <img align="right" width="200px" src="https://fluxml.ai/assets/logo.png"> |
There was a problem hiding this comment.
This is the big Flux logo. My thinking was just to add the small one, as on most of the other repositories.
There was a problem hiding this comment.
https://avatars.githubusercontent.com/u/26222520 might be a better permalink then. I'd also be fine with dumping the small version into https://github.com/FluxML/fluxml.github.io/tree/main/_assets so we have a central place for it across the org.
There was a problem hiding this comment.
Yes that's probably ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the project (or manifest) files for the version of Flux on which these models were run. Maybe useful to have up front?
I guess it's an admission that they aren't all going to stay perfectly current. Better to be honest though.
Also adds entries for a few recent PRs which were missing from the Readme's list.