-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected image dims from HWCN
to WHCN
which solves #235
#306
Conversation
This commit history is borked, but thanks for the contribution! We can merge the fix to permutedims pending fixing the commit history. |
Thanks @DhairyaLGandhi for reviewing. Sorry for all those activities. I was bit confused. Do I need to fix something? |
The |
Thanks @ToucheSir for clearing out. Can you please give me some instruction's how to include only the actual change. |
The easiest way would be to reset this branch back in line with master and create a new commit with the relevant changes. Alternatively, you could create a new branch and cherry-pick the commit, or rewind this branch back in line with master and cherry-pick. |
or (this going to be very bad advice) copy the folders you modified out of the repo, then checkout master, sync with origin, delete this branch, checkout the new branch, copy back the folders, force push on origin, checkout the diff for unwanted changes |
AFAICT the change is a one-liner, so it may be even easier to PR it through the web interface :P |
Sorry again this time trying through the web interface. |
Oh no, you can't add commits to this PR that way. That keeps around the previous commits. You'd either have to start a new PR or clean out all of the commits on this one beforehand and force push. The thing to look for is the commits tab up top showing |
Changed dims in
permutedims
fromHWCN
toWHCN
.