Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected image dims from HWCN to WHCN which solves #235 #306

Closed
wants to merge 0 commits into from

Conversation

aditkumar72
Copy link
Contributor

Changed dims in permutedims from HWCN to WHCN.

@aditkumar72 aditkumar72 deleted the dims branch June 18, 2021 20:43
@aditkumar72 aditkumar72 restored the dims branch June 18, 2021 20:43
@aditkumar72 aditkumar72 reopened this Jun 18, 2021
@DhairyaLGandhi
Copy link
Member

This commit history is borked, but thanks for the contribution! We can merge the fix to permutedims pending fixing the commit history.

@aditkumar72
Copy link
Contributor Author

Thanks @DhairyaLGandhi for reviewing. Sorry for all those activities. I was bit confused. Do I need to fix something?

@ToucheSir
Copy link
Member

The dims branch on your fork has a bunch of unrelated commits from #218. @DhairyaLGandhi was asking if you could just include 27bf1a6 (the actual change) so we can merge it.

@aditkumar72
Copy link
Contributor Author

Thanks @ToucheSir for clearing out. Can you please give me some instruction's how to include only the actual change.
P.S. - I did my research but I didn't understood how to do it.

@ToucheSir
Copy link
Member

ToucheSir commented Jun 19, 2021

The easiest way would be to reset this branch back in line with master and create a new commit with the relevant changes. Alternatively, you could create a new branch and cherry-pick the commit, or rewind this branch back in line with master and cherry-pick.

@CarloLucibello
Copy link
Member

or (this going to be very bad advice) copy the folders you modified out of the repo, then checkout master, sync with origin, delete this branch, checkout the new branch, copy back the folders, force push on origin, checkout the diff for unwanted changes

@ToucheSir
Copy link
Member

AFAICT the change is a one-liner, so it may be even easier to PR it through the web interface :P

@aditkumar72
Copy link
Contributor Author

Sorry again this time trying through the web interface.

@ToucheSir
Copy link
Member

Oh no, you can't add commits to this PR that way. That keeps around the previous commits. You'd either have to start a new PR or clean out all of the commits on this one beforehand and force push. The thing to look for is the commits tab up top showing (1), and that one commit being your corrected dims of the images (HWCN -> WHCN) change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants