Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent post title not being listed correctly #151

Closed
darsnack opened this issue Oct 14, 2022 · 0 comments · Fixed by #152
Closed

Recent post title not being listed correctly #151

darsnack opened this issue Oct 14, 2022 · 0 comments · Fixed by #152

Comments

@darsnack
Copy link
Member

Describe the issue
The recent posts under https://fluxml.ai/blog/ are generated by an hfun in Franklin.jl. The title is set to a page environment variable unless it is unspecified, in which case it gets a generic name like "Post 10". Currently, all blog posts have titles, but not all of them are generated correctly by the hfun.

To Reproduce
Steps to reproduce the behavior (include links to pages or assets):

  1. "Post 10" https://fluxml.ai/blog/ on corresponds to https://fluxml.ai/blogposts/2021-12-1-flux-numfocus/
  2. In the source for the post, the title environment variable is set
  3. The hfun will read the environment variable and give a default if it is nothing:
    titles[i] = something(pagevar(url, :title), "Post $i")
    (currently that is what it is doing)
  4. If you remove the something logic from the code, then you get an error about assigning Nothing to a Vector{String}, confirming that pagevar(url, :title) is returning nothing when it should return the title set in Step 2.

Step 4 makes me think this is Franklin issue @tlienart.

Desktop (please complete the following information):

  • Browser: All
  • Mobile or desktop (specify OS)? Both
tlienart added a commit to tlienart/fluxml.github.io that referenced this issue Oct 14, 2022
This will sort out the problem mentioned [here](FluxML#151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant