Require GPUArrays instead of CUDA #1182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
commented
Mar 12, 2022
Comment on lines
+263
to
-269
| # else # CUDA >= 3.0 -- don't need cufunc(f). | ||
| # # Ordinary broadcasting calls broadcast_forward anyway when certain its' safe, | ||
| # # so perhaps this can be deleted? Possible edge case here: | ||
| # # https://github.com/FluxML/Zygote.jl/pull/1018#issuecomment-873629415 | ||
|
|
||
| @eval @adjoint broadcasted(::CuArrayStyle, f, args...) = | ||
| broadcast_forward(f, args...) |
There was a problem hiding this comment.
Not sure it's safe to delete these.
There was a problem hiding this comment.
If not, changing CuArrayStyle -> AbstractGPUArrayStyle seems pretty safe.
ToucheSir
reviewed
Mar 12, 2022
|
|
||
| @adjoint (::Type{T})(xs::Array) where {T <: CUDA.CuArray} = |
There was a problem hiding this comment.
Good opportunity to change these over to rrule(::ZygoteRuleConfig, ...) instead? IME they're much easier to debug than @adjoint definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the special code for CUDA with that for GPUArrays, which is loaded by CUDA. One motivation is things like FluxML/OneHotArrays.jl#9, which runs GPU tests with JLArray.
Could be loaded unconditionally, but would need to check load times? Not the only use of Requires in Zygote.