-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json logs #6600
Conversation
1 failed and 2 flaky tests on run #22873 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
role list screen > Add blank role |
Test Replay
Screenshots
|
cypress/e2e/add_new_server.js • 2 flaky tests
Test | Artifacts | |
---|---|---|
Server management > Add duplicate Server name |
Test Replay
Screenshots
|
|
Server management > Add server |
Test Replay
Screenshots
|
Review all test suite changes for PR #6600 ↗︎
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6600 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 268 268
Lines 10590 10590
Branches 856 856
=======================================
Hits 9775 9775
Misses 676 676
Partials 139 139 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved modulo thought about config for rotation age+size
I have:
Description
Adds a new env var,
FLOWDB_LOG_DEST
which controls the log destination config item, and changes the default to json files.