Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for buffer while updating executing flows #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mudit1289
Copy link

No description provided.

Copy link

@jithendhir92 jithendhir92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for (ExecutableFlow flow : flows) {
String updateTime = (flow.getUpdateTime()-updateTimeBufferMs) + "";
String execId = (flow.getExecutionId()) + "";
String buffer = (updateTimeBufferMs) + "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is explicit conversion to string required. It will implicitly happen in logger.info ?

@mudit1289 mudit1289 force-pushed the AzkabanPreparingIssue branch from 6306c52 to 9ec6001 Compare September 22, 2023 12:41
@mudit1289 mudit1289 force-pushed the AzkabanPreparingIssue branch from 9ec6001 to e06181f Compare September 22, 2023 12:43
Copy link

@gantashalavenki gantashalavenki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants