Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Remove users access from a shared file #269

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Feature: Remove users access from a shared file #269

merged 2 commits into from
Dec 3, 2020

Conversation

perfectmak
Copy link
Contributor

@perfectmak perfectmak commented Dec 1, 2020 •
edited
Loading

CHANGELOG

  • Adds a rpc method UnshareFilesViaPublicKey` that revokes access of a user from a shared file.
  • Unsharing a file sends a revoked invitation notification to the user and when the user receives this notification, it should verify and remove from them from his list of received files.

@perfectmak perfectmak marked this pull request as ready for review December 2, 2020 11:04
jsonsivar
jsonsivar approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jsonsivar jsonsivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maurycy
maurycy approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@maurycy maurycy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@perfectmak perfectmak merged commit 51f4c46 into develop Dec 3, 2020
@perfectmak perfectmak deleted the feature/ch20165/remove-user-from-shared-file branch December 3, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurycy maurycy maurycy approved these changes

@jsonsivar jsonsivar jsonsivar approved these changes

Assignees

@jsonsivar jsonsivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perfectmak @maurycy @jsonsivar