Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Integration Test & Fixtures Setup #268

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Chore: Integration Test & Fixtures Setup #268

merged 1 commit into from
Dec 10, 2020

Conversation

perfectmak
Copy link
Contributor

@perfectmak perfectmak commented Nov 30, 2020 •
edited
Loading

CHANGELOG

  • Setup Integration Tests suites and also update to run them on CI. The integration test suite is run with ginkgo and uses gomega for assertions. Allowing us to follow a BDD approach to testing.
  • Refactored daemon app startup and shutdown logic, so daemon shutdown by explicitly calling shutdown instead of canceling context. Canceled Context was not working properly with the shutdown inside some of the components, so this was the easiest solution for now while we fix the component's logic. I created this issue to track it.
  • Add coverage report to CI result
  • Fix an issue with OpenSharedFile failing (was caught by the test)
  • Added a simple log level setter via configs passed to the app instance.

@perfectmak perfectmak mentioned this pull request Dec 2, 2020
Closed
@perfectmak perfectmak force-pushed the chore/ch20171/integration-test-setup branch 6 times, most recently from 473b274 to 2b50a68 Compare December 9, 2020 18:32
@perfectmak perfectmak force-pushed the chore/ch20171/integration-test-setup branch from 2b50a68 to d153fc0 Compare December 9, 2020 19:04
maurycy
maurycy approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@maurycy maurycy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. LGTM. 🚀

jsonsivar
jsonsivar approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@jsonsivar jsonsivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this 🙏 💪

@perfectmak perfectmak merged commit b72af25 into develop Dec 10, 2020
@perfectmak perfectmak deleted the chore/ch20171/integration-test-setup branch December 10, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsonsivar jsonsivar jsonsivar approved these changes

@maurycy maurycy maurycy approved these changes

@dmerrill6 dmerrill6 Awaiting requested review from dmerrill6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perfectmak @maurycy @jsonsivar