Allow running Textile client in no-key state #141
Conversation
| err2 := kc.st.Remove([]byte(PublicKeyStoreKey)) | ||
| // Note: currently ignoring error on keychain removal because it's failing randomly. | ||
| // Use GenerateKeyPair with override option instead. | ||
| ring.Remove(PrivateKeyStoreKey) |
There was a problem hiding this comment.
Maybe we can add a bug card with the exact error message.
There was a problem hiding this comment.
core/textile/client.go
Outdated
| // Starts a Textile Client and also initializes default resources for it like a key pair and default bucket. | ||
| // Then leaves the process running to attempt to connect or to initialize if it's not already initialized | ||
| func (tc *textileClient) Start(ctx context.Context, cfg config.Config) error { | ||
| // Create key pair if not present |
There was a problem hiding this comment.
Is this leftover comment?
core/textile/client.go
Outdated
| } | ||
|
|
||
| wasConnectedToHub := tc.isConnectedToHub | ||
|
|
||
| tc.isConnectedToHub = true | ||
|
|
||
| // setup mailbox | ||
| mid, err := tc.uc.SetupMailbox(hubctx) |
There was a problem hiding this comment.
This actually only needs to happen once (per keypair) so maybe this could get moved into the wasConnectedToHub == false case as well to avoid extra network calls.
core/textile/client.go
Outdated
| @@ -125,7 +129,28 @@ func (tc *textileClient) start(ctx context.Context, cfg config.Config) error { | |||
| tc.ConnectToHub(ctx) | |||
There was a problem hiding this comment.
Since ConnectToHub is now called via healthcheck, maybe we can remove this call?
There was a problem hiding this comment.
Removed in 5660fd4
core/textile/client.go
Outdated
| tc.initialize(ctx) | ||
| } | ||
|
|
||
| tc.ConnectToHub(ctx) |
There was a problem hiding this comment.
Should we wrap this in a tc.isConnectedToHub == false clause?
There was a problem hiding this comment.
Updated ConnectToHub to better reflect what it's doing right now. So now it's called checkHubConnection and it will get the token from the store, refresh it if necessary, and connect to mailbox if necessary. If any of these steps fail, tc.isConnectedToHub will be set to false.
…ate-mirror-bucket-on * master: Set ulimit on start (#142) getMetaThreadContext: pass hub Allow running Textile client in no-key state (#141) Sharing: update accept/reject handlers to single func. don't block <-component.WaitForReady() on err Sharing: remove todo for message as we actually need to send it now Sharing: add proper placeholder for sharing API call. Merge master: fix go.mod Remove member struct Remove member collection pieces. Fix broken tests: update mock txl client Sharing: add todo for integrating buckets acl api Remove leftover comment in sharing domain Added message type to message Initial commit for sharing updates, left placeholder for textile acl integration.
Change log
Textile client is now started on boot but does not require a key. Initialization is delayed until there's key
Message channel so that textile can initialize defaults when key is added, and to reset to default state when key is removed.
Fixed delete key response
[ch17853]