Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-973 - Reconfigure module with a sticky ami id stored in ssm #18

Merged
merged 2 commits into from
Apr 4, 2023
Merged

SRE-973 - Reconfigure module with a sticky ami id stored in ssm #18

merged 2 commits into from
Apr 4, 2023

Conversation

automationforthepeople
Copy link
Contributor

  • Refactor module to handle the ami id as an insenstive value allowing terraform to properly determine the plan is noop
  • Add logic to use a data lookup when ami_id is not passed and set the ssm param when it is passed
  • Remove the ami data object that was getting latest by ami id - this makes no sense. Instead we put validation on the ssm param with type = aws:ec2:image

@automationforthepeople
Reconfigure module with a sticky ami id stored in ssm
758dcff 
- Refactor module to handle the ami id as an insenstive value allowing terraform to properly determine the plan is noop
- Add logic to use a data lookup when ami_id is not passed and set the ssm param when it is passed
- Remove the ami data object that was getting latest by ami id - this makes no sense. Instead we put validation on the ssm param with type = aws:ec2:image
@automationforthepeople automationforthepeople requested a review from a team as a code owner April 4, 2023 15:20
@automationforthepeople
Copy link
Contributor Author

plan with TF_VAR_webapi_ami_id=ami-065740d95c02b8bd1 terraform plan:

No changes. Your infrastructure matches the configuration

plan with terraform plan:

No changes. Your infrastructure matches the configuration.

@SaiPrasannaGopularam SaiPrasannaGopularam self-requested a review April 4, 2023 15:51
@automationforthepeople automationforthepeople merged commit 25ef085 into master Apr 4, 2023
@automationforthepeople automationforthepeople changed the title Reconfigure module with a sticky ami id stored in ssm SRE-973 - Reconfigure module with a sticky ami id stored in ssm Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaiPrasannaGopularam SaiPrasannaGopularam SaiPrasannaGopularam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@automationforthepeople @SaiPrasannaGopularam