-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from dart:html
to package:web
#198
Conversation
Allows WASM builds
|
Thanks for your PR 🙏 Please give me some time to check it |
@@ -10,7 +10,7 @@ on: | |||
workflow_dispatch: | |||
|
|||
env: | |||
flutter_version: "3.16.0" | |||
flutter_version: "3.19.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required for web 0.51 or is this change out of scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package:web 0.5.1
is not supported on Flutter 3.16.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it to the stable cherry picks Flutter version I'm using but feel free to set to any lower stable version that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should then increase the min version inside pubspec as well
Currently it's still flutter: ">=3.16.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It's not important for the Dart tool but it does add some clarity for humans. Well spotted!
@@ -14,6 +14,7 @@ dependencies: | |||
sdk: flutter | |||
plugin_platform_interface: ^2.0.2 | |||
shared_preferences: ^2.0.15 | |||
web: ^0.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Migration-Guide https://dart.dev/interop/js-interop/package-web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thx for doing the migration and enable the package be compatible with WASM 👍
dart:html
is not supported by Flutter web WASM (flutter build web --wasm
) compilation. See more at https://docs.flutter.dev/platform-integration/web/wasm#known-limitations.