Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge document corrections in LBM #560

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Conversation

torao
Copy link
Contributor

@torao torao commented Feb 7, 2023

Description

This PR is a document amendment to Ostracon's latest design changes.

  • The role of "voter" and the election of voters have been removed.
  • Minor wording changes to the English text and its application to the Japanese version.

See fix/merge_docs_from_lbm branch for a markdown view of this deliverable.

Closes: #XXX

@torao torao added the C: documentation Classification: Improvements or additions to documentation label Feb 7, 2023
@torao torao requested a review from ulbqb February 7, 2023 02:11
@torao torao self-assigned this Feb 7, 2023
@torao torao requested review from Kynea0b and tnasu as code owners February 7, 2023 02:11
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the Japanese version, I thought it would be better to unify the following.

  • 合意メカニズム、合意アルゴリズム、コンセンサススキーム
  • 未確定、未承認

docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/ja/02-consensus.md Outdated Show resolved Hide resolved
docs/ja/02-consensus.md Outdated Show resolved Hide resolved
docs/ja/01-overview.md Outdated Show resolved Hide resolved
docs/en/02-consensus.md Outdated Show resolved Hide resolved
docs/en/03-tx-sharing.md Outdated Show resolved Hide resolved
docs/en/02-consensus.md Outdated Show resolved Hide resolved
docs/ja/02-consensus.md Outdated Show resolved Hide resolved
docs/en/03-tx-sharing.md Outdated Show resolved Hide resolved
Kynea0b
Kynea0b previously approved these changes Feb 10, 2023
@torao torao force-pushed the fix/merge_docs_from_lbm branch 3 times, most recently from 8616538 to 6fa6cae Compare February 17, 2023 06:43
@torao torao requested review from ulbqb and Kynea0b February 17, 2023 06:54
@torao torao force-pushed the fix/merge_docs_from_lbm branch from 6fa6cae to f41d74b Compare February 17, 2023 07:02
@torao
Copy link
Contributor Author

torao commented Feb 17, 2023

@ulbqb
未承認 and コンセンサススキーム unified as 未確定 and 合意メカニズム respectively. But Algorithms are left separate as it's unnatural to treat them as essentially equivalent to Mechanisms.

@torao torao merged commit 2262017 into Finschia:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: documentation Classification: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants