Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set maximum value for SignedMsgType #531

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix: Set maximum value for SignedMsgType #531

merged 1 commit into from
Dec 15, 2022

Conversation

Kynea0b
Copy link
Contributor

@Kynea0b Kynea0b commented Dec 14, 2022

Description

TestMaxVoteBytes was tested by setting the maximum value for all of the Vote fields; only Type had no maximum value set; the maximum value for Type is ProposalType, so ProposalType is set to Type in this PR.

@Kynea0b Kynea0b requested review from torao and tnasu as code owners December 14, 2022 10:00
@torao torao added the C: bug Classification: Something isn't working label Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #531 (f6ae450) into main (2f25796) will increase coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   66.02%   66.12%   +0.10%     
==========================================
  Files         279      279              
  Lines       38045    38045              
==========================================
+ Hits        25119    25158      +39     
+ Misses      11127    11093      -34     
+ Partials     1799     1794       -5     
Impacted Files Coverage Δ
privval/signer_server.go 89.28% <0.00%> (-5.36%) ⬇️
privval/signer_endpoint.go 76.92% <0.00%> (-3.30%) ⬇️
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
state/execution.go 67.46% <0.00%> (-0.73%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (-0.62%) ⬇️
statesync/syncer.go 82.23% <0.00%> (-0.58%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
consensus/reactor.go 75.63% <0.00%> (+0.35%) ⬆️
light/client.go 61.71% <0.00%> (+0.45%) ⬆️
p2p/pex/addrbook.go 71.57% <0.00%> (+0.50%) ⬆️
... and 9 more

@Kynea0b Kynea0b merged commit 19b26f9 into Finschia:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants