Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MaxHeaderSize
represents the maximum size of theHeader
encoded in ProtocolBuffers (ChannelID
seems to be the arbitrary length, so it's treated as 'softmax'); Protobuf encodes integers with variable length, so the size isn't fixed, but the maximum value of theProof
andRound
fields added in Ostracon were not calculated to this maximum value.This PR re-adjust the
MaxHeaderSize
to be the maximum size thatProof
andRound
can take. In addition, for clarity, I leave the Tendermint constant of 626 to add/remove the size of the field we have changed for theHeader
.Closes: #XXX