Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix to input value to GITHUB_OUTPUT correctly #518

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Dec 1, 2022

Description

https://github.com/line/ostracon/actions/runs/3589776951/jobs/6042534542
The e2e test always seem to fail in build phase. I fixed to input value to GITHUB_OUTPUT correctly.

@ulbqb ulbqb force-pushed the fix/e2e_test branch 2 times, most recently from bb7b40c to 9c99a57 Compare December 1, 2022 08:18
@ulbqb ulbqb changed the title test fix: fix CACHE_FILE value in e2e test Dec 1, 2022
@ulbqb ulbqb changed the title fix: fix CACHE_FILE value in e2e test fix: fix to specify CACHE_FILE value correctly Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #518 (5bf2579) into main (07a894b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5bf2579 differs from pull request most recent head 5e75579. Consider uploading reports for the commit 5e75579 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   65.62%   65.62%           
=======================================
  Files         279      279           
  Lines       38032    38030    -2     
=======================================
+ Hits        24957    24959    +2     
+ Misses      11276    11273    -3     
+ Partials     1799     1798    -1     
Impacted Files Coverage Δ
consensus/state.go 74.05% <ø> (+0.43%) ⬆️
types/params.go 78.99% <ø> (ø)
types/voter_set.go 85.20% <100.00%> (+0.42%) ⬆️
libs/events/events.go 93.23% <0.00%> (-5.27%) ⬇️
privval/socket_listeners.go 79.72% <0.00%> (-4.06%) ⬇️
privval/signer_listener_endpoint.go 88.88% <0.00%> (-2.39%) ⬇️
p2p/switch.go 65.08% <0.00%> (-1.45%) ⬇️
p2p/pex/addrbook.go 71.57% <0.00%> (-0.51%) ⬇️
types/block.go 77.21% <0.00%> (+0.10%) ⬆️
blockchain/v0/pool.go 79.84% <0.00%> (+0.25%) ⬆️
... and 6 more

@ulbqb ulbqb marked this pull request as ready for review December 1, 2022 08:27
@ulbqb ulbqb requested review from Kynea0b, torao and tnasu as code owners December 1, 2022 08:27
@ulbqb ulbqb marked this pull request as draft December 1, 2022 08:46
@ulbqb ulbqb changed the title fix: fix to specify CACHE_FILE value correctly fix: fix to input GITHUB_OUTPUT correctly Dec 1, 2022
@ulbqb ulbqb changed the title fix: fix to input GITHUB_OUTPUT correctly fix: fix to input value to GITHUB_OUTPUT correctly Dec 1, 2022
@ulbqb ulbqb self-assigned this Dec 1, 2022
@ulbqb ulbqb marked this pull request as ready for review December 1, 2022 09:19
@ulbqb ulbqb requested a review from Mdaiki0730 December 1, 2022 09:20
@torao torao added the C: bug Classification: Something isn't working label Dec 1, 2022
@ulbqb ulbqb merged commit 99feabe into Finschia:main Dec 1, 2022
@ulbqb ulbqb deleted the fix/e2e_test branch December 1, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants