Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with: https://github.com/line/link/issues/1154
Description
Amino
encoding is expensive because of reflection. Especially foraccount
, it's too expensive due to encode and decode so many times. To optimize performance, I'd like to implement customAmino
implementation withoutreflection
. For this, we need to implementcrypto
s marshaller intendermint
.Please note that it's not production ready quality but just intend to check the upper bound that we could achieve. we need more test code for production. And also I don't implement for
PubKeyMultisigThreshold
because it's not used inload test
scenario.For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer