Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix init_multi script(grpc-web port) #58

Merged
merged 1 commit into from
Apr 18, 2022
Merged

chore: fix init_multi script(grpc-web port) #58

merged 1 commit into from
Apr 18, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Apr 14, 2022

Description

fix init_multi.sh for grpc-web port

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@dudong2 dudong2 self-assigned this Apr 14, 2022
zemyblue
zemyblue approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 requested a review from 0Tech April 18, 2022 02:03
0Tech
0Tech approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit eb04895 into Finschia:main Apr 18, 2022
@dudong2 dudong2 deleted the dudong2/chore/init-node-script branch April 18, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech 0Tech approved these changes

Assignees

@dudong2 dudong2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudong2 @zemyblue @0Tech