Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix goreleaser error and replace release-build #291

Merged
merged 2 commits into from
Oct 24, 2023
Merged

ci: fix goreleaser error and replace release-build #291

merged 2 commits into from
Oct 24, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 24, 2023 •
edited
Loading

Description

closes: #231

  • fix goreleaser error and replace release-build
  • add macOS binary in the release note assets.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

The assets are added like below.
스크린샷 2023-10-24 오후 12 36 37

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@zemyblue zemyblue marked this pull request as ready for review October 24, 2023 03:33
@zemyblue zemyblue self-assigned this Oct 24, 2023
@zemyblue zemyblue added the ci label Oct 24, 2023
tkxkd0159
tkxkd0159 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit c563d6d into Finschia:release/v2.0.x Oct 24, 2023
@zemyblue zemyblue deleted the feat/goreleaser branch October 24, 2023 04:36
@zemyblue zemyblue mentioned this pull request Nov 7, 2023
Merged
@zemyblue zemyblue mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

@ulbqb ulbqb Awaiting requested review from ulbqb

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@zemyblue zemyblue

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zemyblue @torao @tkxkd0159