Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement validateGasWanted() #65

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

wetcod
Copy link
Contributor

@wetcod wetcod commented Feb 4, 2021

Related https://github.com/line/link/issues/1176

Description

cherry-pick #48

Motivation and context

How has this been tested?

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Sangyeop.lee and others added 2 commits February 4, 2021 19:46
* feat: impl `validateGasWanted()`

* fix: lint error

* chore: bump up tendermint

* fix: tests to use `grpc` instead of `socket`
@wetcod wetcod self-assigned this Feb 4, 2021
server/start.go Outdated
@@ -130,7 +130,7 @@ func startStandAlone(ctx *Context, appCreator AppCreator) error {

app := appCreator(ctx.Logger, db, traceWriter)

svr, err := server.NewServer(addr, "socket", app)
svr, err := server.NewServer(addr, "grpc", app)
Copy link
Contributor

@jinsan-line jinsan-line Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is not needed for this PR.

Copy link
Contributor Author

@wetcod wetcod Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinsan-line I fixed it. Thank you. PTAL d3e7303

@wetcod wetcod merged commit 0b8ae2c into Finschia:develop Feb 5, 2021
egonspace pushed a commit that referenced this pull request Mar 28, 2021
MERGING wasmd v0.10.0..v0.11.1:

* wasmd v0.10.0

* go-cosmwasm 0.11.0-alpha1 and fix compiler issues

* Updated contracts from cosmwasm v0.11.0-alpha3

https://github.com/CosmWasm/cosmwasm/releases/tag/v0.11.0-alpha3

* Return TimeNanos along with BlockInfo

* Fix gas on tests

* Fix reflect tests

* Error message cleanup

* Cleanup from pr review

* Update go-cosmwasm to v0.11.0-alpha2, contracts to v0.11.0-alpha4

* Update code/tests to new version

* Fix old contract naming in integration tests

* Implemented files called general_consts.go to all modules that heavly relied on  the duplicated "CLientID : 1"
Future duplicated variables across the entire module can also be added to it, centralizing therefore all os those kind of values.

* Closes #10 Implemented files called general_consts.go to all modules that heavly relied on the duplicated "ClientID : 1"

* Add more queries on reflect contract

* Test QuerySmart and QueryRaw reflected via contract

* Add test for the response of StakingQuery::Validators

* Add test for StakingQuery::AllDelegations

* Cleanup from PR comments

* Add tests for StakingQuery::{Delegation,BondedDenom}

* Increment x/wasm error codes by 1

* Return raw stored bytes for raw queries

* Update raw query REST response

* Use json.RawMessage for better encoding of REST interface on raw queries

* Test QueryContractState based on binary

* Test nil key and adapt docs

* Better calculation of Delegation.CanRedelegate

* Wrote gnarly query to get outstanding rewards for delegator

* Update app.go for new constructor

* Minor PR cleanup

* Ensure the DelegationQuery doesn't modify the state

* Extra safe we do not write during the query

* Prevent integer overflow

* Review feedback

* Add test showing WasmQuery::Raw fails for missing responses

* Update to go-cosmwasm v0.11.0-rc and raw query tests pass

* Update to go-cosmwasm v0.11.0

* Download newest contracts

* Base64 encoded return data on wasm raw query REST endpoint

* Manually encode as base64 as auto-encoded doesn't work

FIXES FOR MERGING:

* fix: add more properties to wasm keeper constructor

- add encodeRouter, queryRouter, distribution keeper
- update go.sum

* fix: replace contracts with cosmwasm version 0.12.0

* fix: add a newline in the end of download_releases.sh

* fix: replace contract for perf_check

Co-authored-by: Yongwoo Lee <[email protected]>
Co-authored-by: Ethan Frey <[email protected]>
Co-authored-by: Gustavo H. M. Silva <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Alex Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants