-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 2025-release with design language changes and o3 migration path #1970
Conversation
1c9f29c
to
76b2f6b
Compare
76b2f6b
to
945d8a6
Compare
945d8a6
to
f521b58
Compare
f521b58
to
1c9f29c
Compare
1c9f29c
to
e03e86e
Compare
e03e86e
to
90a3fa2
Compare
90a3fa2
to
4289b61
Compare
4289b61
to
13f4cba
Compare
13f4cba
to
845c0e1
Compare
845c0e1
to
34e49cc
Compare
34e49cc
to
ef3e3db
Compare
ef3e3db
to
7ac6b33
Compare
Final README.md and MIGRATION.md updates to trigger a release. See: 2002f6d
ac4d007
to
6a9b7c8
Compare
| :----------: | :-----------: | :----------------: | :---------------------------------------------------: | | ||
| ✨ active | 3 | N/A | [migrate to v3](MIGRATION.md#migrating-from-v2-to-v3) | | ||
| ╳ deprecated | 2 | 2.3 | [migrate to v2](MIGRATION.md#migrating-from-v1-to-v2) | | ||
| ╳ deprecated | 1 | - | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From v1
to v3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to v2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I was looking at the diff, I could see previous version was v1 only in the table, but then it went to v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :----------: | :-----------: | :----------------: | :---------------------------------------------------: | | ||
| ✨ active | 3 | N/A | [migrate to v3](MIGRATION.md#migrating-from-v2-to-v3) | | ||
| ╳ deprecated | 2 | 2.3 | - | | ||
| ╳ deprecated | 1 | - | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it's missing migration guide for v2, and I didn't want to write one retrospectively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would love clarification on why it went from v1
to v3
on the bits I've flagged up.
Otherwise than that, it all looks great. 77 files reviewed!
To review: Ensure all components we expect to release (listed below) have a file change to trigger an automated release. Ensure other components, do not.
This releases a new design language and visually breaking changes. This includes mobile optimised typography, icons, and buttons.
Release a major for "o3" components:
Should not release o2 components with an o3 alternative:
Release a major for remaining "o2" components to remove deprecated components as dependencies: