Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 2025-release with design language changes and o3 migration path #1970

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Feb 19, 2025

To review: Ensure all components we expect to release (listed below) have a file change to trigger an automated release. Ensure other components, do not.

This releases a new design language and visually breaking changes. This includes mobile optimised typography, icons, and buttons.

Release a major for "o3" components:

  • o3-foundation
  • o3-button
  • o3-editorial-typography
  • o3-tooltip

Should not release o2 components with an o3 alternative:

  • o-normalise
  • o-fonts
  • o-spacing
  • o-colors
  • o-icons
  • o-typography
  • o-buttons
  • o-editorial-typography
  • o-quote
  • o-big-number

Release a major for remaining "o2" components to remove deprecated components as dependencies:

  • o-tooltip
  • o-video
  • o-topper
  • o-stepped-progress
  • o-top-banner
  • o-tabs
  • o-subs-card
  • o-teaser-collection
  • o-table
  • o-syntax-highlight
  • o-teaser
  • o-overlay
  • o-share
  • o-labels
  • o-social-follow
  • o-message
  • o-layout
  • o-meter
  • o-footer-services
  • o-loading
  • o-multi-select
  • o-header-services
  • o-footer
  • o-ft-affiliate-ribbon
  • o-forms
  • o-header
  • o-editorial-layout
  • o-comments
  • g-audio
  • o-cookie-message
  • o-expander
  • o-banner
  • o-autocomplete
  • n-notification
  • ft-concept-button

@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 18:54 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 1c9f29c to 76b2f6b Compare February 19, 2025 18:56
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 18:57 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 76b2f6b to 945d8a6 Compare February 19, 2025 18:58
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 18:58 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 945d8a6 to f521b58 Compare February 19, 2025 19:02
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 19:02 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from f521b58 to 1c9f29c Compare February 19, 2025 19:03
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 19:04 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 1c9f29c to e03e86e Compare February 19, 2025 19:05
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 19:05 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from e03e86e to 90a3fa2 Compare February 19, 2025 19:06
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 19:06 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 90a3fa2 to 4289b61 Compare February 19, 2025 19:08
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 19, 2025 19:08 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 4289b61 to 13f4cba Compare February 20, 2025 08:40
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 08:40 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 13f4cba to 845c0e1 Compare February 20, 2025 08:41
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 08:41 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 845c0e1 to 34e49cc Compare February 20, 2025 08:42
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 08:42 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from 34e49cc to ef3e3db Compare February 20, 2025 08:45
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 08:45 Inactive
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from ef3e3db to 7ac6b33 Compare February 20, 2025 08:46
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 08:46 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 09:29 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 09:46 Inactive
Base automatically changed from 2025-release to main February 20, 2025 10:01
Final README.md and MIGRATION.md updates to trigger a release.

See: 2002f6d
@notlee notlee force-pushed the 2025-release-o2-bump-migration-guides branch from ac4d007 to 6a9b7c8 Compare February 20, 2025 10:20
@notlee notlee temporarily deployed to origami-webs-2025-relea-sdlm30 February 20, 2025 10:21 Inactive
@notlee notlee marked this pull request as ready for review February 20, 2025 10:23
@notlee notlee requested review from a team as code owners February 20, 2025 10:23
@notlee notlee changed the title docs: Add migration guides for o2 bumps Make 2025-release with design language changes and o3 migration path Feb 20, 2025
@notlee notlee enabled auto-merge (squash) February 20, 2025 10:31
@notlee notlee removed request for a team February 20, 2025 10:34
Comment on lines +353 to +356
| :----------: | :-----------: | :----------------: | :---------------------------------------------------: |
| ✨ active | 3 | N/A | [migrate to v3](MIGRATION.md#migrating-from-v2-to-v3) |
| ╳ deprecated | 2 | 2.3 | [migrate to v2](MIGRATION.md#migrating-from-v1-to-v2) |
| ╳ deprecated | 1 | - | N/A |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From v1 to v3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to v2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was looking at the diff, I could see previous version was v1 only in the table, but then it went to v3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-20 at 10 51 36

Comment on lines +152 to +155
| :----------: | :-----------: | :----------------: | :---------------------------------------------------: |
| ✨ active | 3 | N/A | [migrate to v3](MIGRATION.md#migrating-from-v2-to-v3) |
| ╳ deprecated | 2 | 2.3 | - |
| ╳ deprecated | 1 | - | N/A |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's missing migration guide for v2, and I didn't want to write one retrospectively

Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would love clarification on why it went from v1 to v3 on the bits I've flagged up.

Otherwise than that, it all looks great. 77 files reviewed!

@notlee notlee merged commit 3be858a into main Feb 20, 2025
46 checks passed
@notlee notlee deleted the 2025-release-o2-bump-migration-guides branch February 20, 2025 10:50
This was referenced Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants