Remove Chai #320
Merged
Remove Chai #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chai v5 is ESM-only which would be a really big migration. We're not doing any complicated assertions in the tests here so I think it makes sense to just switch to the built-in `assert` module. We get to drop a dependency (just under 1MB) and I think assert is easier to understand anyway.
rowanmanning
requested review from
next-team,
ft-dependency-auto-merger and
a team
as code owners
CyntiBinti
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chai v5 is ESM-only which would be a really big migration. We're not doing any complicated assertions in the tests here so I think it makes sense to just switch to the built-in
assertmodule. We get to drop a dependency (just under 1MB) and I think assert is easier to understand anyway.