Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for several reasons:
AWS SDK v2 is no longer supported which is a risk. It also outputs very annoying deprecation warnings all the time
AWS SDK v2 is 98.1 MB!!! That's too big and it means that every single app that uses n-express will be installing aws-sdk regardless of whether it's actually used. The CloudWatch client is a still-not-great-but-much-better 1MB.
Testing locally
This is fairly easy to test locally. You need to get credentials for the
FT Tech Infrastructure Prod
AWS account and export them as environment variables. You can do this via AWS Login - clickAccess keys
instead ofFT-Engineer
.Now add the following to a new JavaScript file and run it via
node
. You should see health check output:See-also: CPREL-1201