Remove moment

[rowanmanning]

Slight side-track, but oh well, here we are! We don't need Moment for these use-cases, and they're probably clear enough without needing any date manipulation/parsing libraries.

Date addition / subtraction

We can add/subtract using regular date. The following code to subtract seconds is equivalent:

function runMoment(samplePeriod) {
  const timeWindow = samplePeriod * 1.5;
  const now = moment();
  const startTime = now.subtract(timeWindow, 'seconds');
  return startTime.toISOString();
}

function runDate(samplePeriod) {
  const timeWindowInMs = (samplePeriod * 1.5) * 1000;
  const now = new Date();
  const startTime = new Date(now.getTime() - timeWindowInMs);
  return startTime.toISOString();
}

console.log("moment", runMoment(60 * 5));
console.log("js", runDate(60 * 5));

The following code to add two weeks to a date is equivalent:

function runMoment() {
  const now = moment();
  const limitDate = moment().add(2, 'weeks');
  return limitDate.toISOString();
}

function runDate() {
  const now = new Date();
  const limitDate = new Date();
  limitDate.setDate(now.getDate() + (2 * 7));
  return limitDate.toISOString();
}

console.log("moment", runMoment());
console.log("js", runDate());

Date comparison

Dates can be compared with regular operators:

console.log(new Date('2023-01-01') > new Date('2024-01-01'));

Date parsing

Date parsing is generally fine too especially in ISO format, we can do a little bit of extra validation but tbh I don't think it's needed - we can just trust the date format that the Fastly API returns (it's the only place this date can come from). These are the same:

console.log(moment("2024-01-26T10:00:00Z", 'YYYY-MM-DDTHH:mm:ssZ').toISOString());
console.log(new Date("2024-01-26T10:00:00Z").toISOString());