Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase interval between Heroku log drain health checks #205

Merged

Conversation

andygout
Copy link
Contributor

@andygout andygout commented Sep 23, 2022

The README for this repo says that the options for check objects include:

interval: time between checks in milliseconds or any string compatible with ms [default: 1minute]

We are currently experiencing the below error for several apps:

"Heroku log drain configuration check failed to fetch data: heroku responded with a 429 status code"

It seems unnecessary for this to be checked at one minute intervals because it is not a condition that will change will a high amount of regularity and given the effect it is having on contributing to reaching our Heroku API key limit, it seems judicious to reduce its impact.

Perhaps one day intervals is too extreme and happy to take a steer on what might be a more suitable interval.

@andygout andygout requested review from a team as code owners September 23, 2022 09:59
@rowanmanning
Copy link
Member

I thought we built this to only ever check when the app starts, rather than on an interval 🤔 give me a moment, I'm gonna investigate what happened here before approving (just in case we did do that and it's unclear)

@andygout
Copy link
Contributor Author

The next-preflight check has gone from healthy to unhealthy and back again several times in the last hour, which indicates that the healthcheck is being performed with a certain amount of regularity.

If it could run only when the app starts that would definitely be the ideal (i.e. even fewer requests).

Copy link
Member

@rowanmanning rowanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 good catch, hopefully it helps. We'll also need an n-express PR which bumps the version

@andygout andygout merged commit 8c101db into main Sep 23, 2022
@andygout andygout deleted the increase-interval-between-heroku-log-drain-health-checks branch September 23, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants