FTDCS-196 - Update testing #187
Conversation
| @@ -5,7 +5,7 @@ const fixture = require('./fixtures/config/pingdomCheckFixture.js').checks[0]; | |||
| const PingdomCheck = require('../src/checks/pingdom.check'); | |||
|
|
|||
| describe('Pingdom Check', function() { | |||
| it('should fail and return a deprecation message', function() { | |||
| it('should fail and return a deprecation message', function(done) { | |||
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| exit: true | |||
There was a problem hiding this comment.
a bit concerning that we still need to rely on mocha to force exit (I see that in mocha v4 and below it force exits by default), it'll be good to understand what processes we need to clean up - but don't worry as it's beyond the scope of your ticket, I'll review this another time
There was a problem hiding this comment.
I think this is all ok but I'm certainly no JavaScript testing expert.
In some commits I did find it a little bit difficult to see what had changed in between the code structure changes - for example in 27a02b5 the actual diff is quite small compared to the other changes in the commit.
Just In Case I am going to fix the format in the first place for the following PRs. |
doneparameter.