Support a dot in repo names. #114
Merged
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Ebi parses https://github.com/financial-times/ft.com-cdn as https://github.com/financial-times/ft, which redirects and returns files from https://github.com/financial-times/fta This commit updates `GITHUB_REPO_REGEX` to match dots in the repo name. This however means `.git` is also matched, so `.git` is removed first as part of the `extractOwnerAndRepo` method. _Note: My previous attempt to do everything in a regex, without removing `.git` first didn't go great. I ended up with the repo name either being in group 3 or 4: `^(?:\S*github\.com(?:\/|:))?([\w-]+)\/(([\w-\.]+)(?:\.git)|([\w-\.]+))`_
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
👋 Happy for me to merge and release? |
|
yes! sorry for the delay 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Ebi parses https://github.com/financial-times/ft.com-cdn
as https://github.com/financial-times/ft, which redirects and returns
files from https://github.com/financial-times/fta
This commit updates
GITHUB_REPO_REGEXto match dots in the reponame. This however means
.gitis also matched, so.gitisremoved first as part of the
extractOwnerAndRepomethod.Note: My previous attempt to do everything in a regex, without removing
.gitfirst didn't go great. I ended up with the repo name either beingin group 2 or 3:
^(?:\S*github\.com(?:\/|:))?([\w-]+)\/(?:([\w-\.]+)(?:\.git)|([\w-\.]+))