Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPPSF-5725-add-context #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tsvetko24
Copy link

@tsvetko24 tsvetko24 commented Dec 19, 2024

Description

What

Added context to the project as this project is missed when added context to Dockerfile and to circleci/config.yml

Why

UPPSF-5725

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to. E.g.

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"

  • Test coverage is not significantly decreased
  • All PR checks have passed
  • Changes are deployed on dev before asking for review
  • Documentations remains up-to-date
    • OpenAPI definition file is updated
    • README file is updated
    • Documentation is updated in upp-docs and upp-public-docs
    • Architecture diagrams are updated

This Pull Request follows the rules described in our Pull Requests Guide

@tsvetko24 tsvetko24 requested a review from a team as a code owner December 19, 2024 15:58
Copy link

coveralls-official bot commented Dec 19, 2024

Coverage Status

coverage: 72.906%. remained the same
when pulling 2585de4 on feature/UPPSF-5725-add-context
into 67a5a2d on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants