Fix corner case when the mesh parent node does not exist #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsanghrajka
approved these changes
Sep 24, 2024
pirlande-fw
deleted the
BIM-325-Converter-Fix-gltfpack-issue-on-some-models-with-unexpected-gltf-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BIM-325 | [Converter] Fix gltfpack issue on some models with unexpected gltf structure]
This PR aims at fixing some corner cases where some generated gltf files have meshes with no parent nodes. In this case, the merged information is not added since information is missing. This is ok for the 3 models we have in this case that do not carry any metadata after the main conversion.