-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup TODO for speculative authenticate #4143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4143 +/- ##
==========================================
- Coverage 74.89% 73.92% -0.98%
==========================================
Files 353 353
Lines 22680 22680
==========================================
- Hits 16987 16767 -220
- Misses 4413 4638 +225
+ Partials 1280 1275 -5
... and 30 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
henvic
previously approved these changes
Mar 5, 2024
AlekSi
reviewed
Mar 5, 2024
AlekSi
approved these changes
Mar 6, 2024
rumyantseva
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both TODO does not seem to be related to speculative authenticate 🤔, so I created issues for them. Let me know if I'm wrong.
One is about supporting
filter
inusersInfo
command #4141, another is creating user for$external
database #4142.Closes #3777.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.