Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --skip in envtool tests run #3805

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

KrishnaSindhur
Copy link
Contributor

@KrishnaSindhur KrishnaSindhur commented Dec 4, 2023

Description

Closes #3787 .

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@KrishnaSindhur KrishnaSindhur requested review from a team and AlekSi as code owners December 4, 2023 11:16
@KrishnaSindhur KrishnaSindhur marked this pull request as draft December 4, 2023 11:16
@AlekSi AlekSi added this to the Next milestone Dec 4, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 4, 2023
@KrishnaSindhur
Copy link
Contributor Author

@AlekSi i have just created draft to check with you is this way we need to add skip for test on highlevel?

@AlekSi
Copy link
Member

AlekSi commented Dec 4, 2023

@KrishnaSindhur yep!

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark PR as ready for review when it is ready for review

Copy link
Contributor

mergify bot commented Dec 6, 2023

@KrishnaSindhur this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Dec 6, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3db735b) 75.48% compared to head (871dcf3) 75.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
- Coverage   75.48%   75.37%   -0.12%     
==========================================
  Files         325      325              
  Lines       24873    24873              
==========================================
- Hits        18776    18747      -29     
- Misses       4979     5003      +24     
- Partials     1118     1123       +5     

see 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.39% <ø> (-0.13%) ⬇️
hana-1 ?
integration 72.39% <ø> (-0.13%) ⬇️
mongodb-1 5.23% <ø> (ø)
postgresql-1 50.93% <ø> (+0.05%) ⬆️
postgresql-2 53.24% <ø> (ø)
postgresql-3 52.21% <ø> (+<0.01%) ⬆️
sqlite-1 50.26% <ø> (+0.10%) ⬆️
sqlite-2 52.31% <ø> (-0.04%) ⬇️
sqlite-3 51.29% <ø> (-0.06%) ⬇️
unit 31.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi
Copy link
Member

AlekSi commented Dec 14, 2023

@KrishnaSindhur any updates? Anything we could help you with?

@KrishnaSindhur KrishnaSindhur marked this pull request as ready for review December 15, 2023 05:05
@AlekSi AlekSi modified the milestones: v1.17.0, Next Dec 18, 2023
@AlekSi AlekSi changed the title add: skip flag for test Add support for --skip in envtool tests run Dec 20, 2023
@AlekSi AlekSi enabled auto-merge (squash) December 20, 2023 03:55
auto-merge was automatically disabled December 20, 2023 04:16

Head branch was pushed to by a user without write access

@AlekSi AlekSi enabled auto-merge (squash) December 20, 2023 16:37
@AlekSi AlekSi requested review from a team, henvic and noisersup December 20, 2023 16:40
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi merged commit df1499d into FerretDB:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support --skip for envtool tests run
4 participants