Fix applying dark scheme when QT_STYLE_OVERRIDE is set #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase on top of my last change where I ran clang-formatting? |
polter-rnd
force-pushed
the
fix_dark_themes
branch
from
0f87acb to
6932a79
Compare
|
I'm not sure it's the right place where to put your fix. Wouldn't https://github.com/FedoraQt/QGnomePlatform/blob/master/src/common/gnomesettings.cpp#L214 be a better place? Do you want to know whether tu use |
polter-rnd
force-pushed
the
fix_dark_themes
branch
from
6932a79 to
fe6ed4a
Compare
When QT_STYLE_OVERRIDE is set to something like "Adwaita-dark" it breaks the theme since it doesn't apply the corresponding color scheme. We should rely on QT_STYLE_OVERRIDE when deciding whether to use the dark theme. Signed-off-by: Pavel Artsishevsky <[email protected]>
polter-rnd
force-pushed
the
fix_dark_themes
branch
from
fe6ed4a to
3039ce1
Compare
Yes, exactly
Seems right, thank you. I've updated my commit, it works this way too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
QT_STYLE_OVERRIDEis set to something likeAdwaita-darkit breaks the theme since it doesn't apply the corresponding color scheme.We should check if we should force dark color sheme similarly to how it's done in
GnomeSettings::styleNames().P.S. it's fix for a regression that likely appeared in 28f14d3